Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove npx only-allow pnpm preinstall hook and devDep #103

Merged
merged 2 commits into from
Aug 9, 2023

Conversation

chrisrng
Copy link
Contributor

@chrisrng chrisrng commented Aug 9, 2023

Fixes #90

While it can help first-time developers avoid a bounce, the use of only-allow with npx also means this does not work on boxes which do not have internet access, most notably internal CI boxes. Since there are alternative ways to solve the first-user flow (documentation, the fact that all package managers flag up the fact that you are using a different manager than the lock file in the repo, etc.), this removes this entirely.

@gitKrystan gitKrystan merged commit c6e2316 into ember-tooling:main Aug 9, 2023
@chrisrng chrisrng deleted the chrisrng/remove-onlyallow branch August 9, 2023 18:36
@gitKrystan gitKrystan added the bug Something isn't working label Aug 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Usage of only-allow
2 participants