ARM64: Embed manifest properly (#4718)

dscho · Git for Windows Build Agent · commit 94ce966bd54f · 2024-01-26T22:58:05.000Z
Teach our ARM64 based builds to embed the manifest file correctly. This fixes #4707
diff --git a/contrib/buildsystems/CMakeLists.txt b/contrib/buildsystems/CMakeLists.txt
@@ -237,6 +237,7 @@ if(CMAKE_C_COMPILER_ID STREQUAL "MSVC")
 	set(CMAKE_RUNTIME_OUTPUT_DIRECTORY_DEBUG ${CMAKE_BINARY_DIR})
 	set(CMAKE_RUNTIME_OUTPUT_DIRECTORY_RELEASE ${CMAKE_BINARY_DIR})
 	add_compile_options(/MP /std:c11)
+	add_link_options(/MANIFEST:NO)
 endif()
 
 #default behaviour
diff --git a/contrib/buildsystems/Generators/Vcxproj.pm b/contrib/buildsystems/Generators/Vcxproj.pm
@@ -198,7 +198,6 @@ sub createProject {
       <AdditionalDependencies>\$(VCPKGLibs);\$(AdditionalDependencies)</AdditionalDependencies>
       <AdditionalOptions>invalidcontinue.obj %(AdditionalOptions)</AdditionalOptions>
       <EntryPointSymbol>$entrypoint</EntryPointSymbol>
-      <ManifestFile>$cdup\\compat\\win32\\git.manifest</ManifestFile>
       <SubSystem>$subsystem</SubSystem>
     </Link>
 EOM
diff --git a/git.rc b/git.rc
@@ -1,3 +1,4 @@
+#include<winuser.h>
 1 VERSIONINFO
 FILEVERSION     MAJOR,MINOR,MICRO,PATCHLEVEL
 PRODUCTVERSION  MAJOR,MINOR,MICRO,PATCHLEVEL

Original file line number	Diff line number	Diff line change
`@@ -1,3 +1,4 @@`
	`1`	`+#include<winuser.h>`
`1`	`2`	`1 VERSIONINFO`
`2`	`3`	`FILEVERSION MAJOR,MINOR,MICRO,PATCHLEVEL`
`3`	`4`	`PRODUCTVERSION MAJOR,MINOR,MICRO,PATCHLEVEL`