Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Renovate Update dependency @giscus/react to v2.2.3 failing with Docusaurus #811

Closed
andrewm4894 opened this issue Nov 17, 2022 · 2 comments
Closed

Comments

@andrewm4894
Copy link

Hello,

Just wanted to mention that i seem to be having some sort of dependency issue building my docusarus blog that maybe seems like might be giscus related? (not sure how the depenency management here really works tbh but though better to mention it).

Just wanted to mention in case is anything that might break for others using docusarus and giscus etc.

Error i see is (netlify link below should work)

5:33:32 PM: Module not found: Error: Can't resolve 'react/jsx-runtime' in '/opt/build/repo/node_modules/@giscus/react/dist'
Did you mean 'jsx-runtime.js'?
5:33:32 PM: BREAKING CHANGE: The request 'react/jsx-runtime' failed to resolve only because it was resolved as fully specified
5:33:32 PM: (probably because the origin is strict EcmaScript Module, e. g. a module with javascript mimetype, a '*.mjs' file, or a '*.js' file where the package.json contains '"type": "module"').
5:33:32 PM: The extension in the request is mandatory for it to be fully specified.
5:33:32 PM: Add the extension to the request.
5:33:32 PM: [ERROR] Client bundle compiled with errors therefore further build is impossible.
5:33:32 PM: ​
5:33:32 PM: ────────────────────────────────────────────────────────────────
5:33:32 PM:   "build.command" failed                                        
5:33:32 PM: ────────────────────────────────────────────────────────────────
5:33:32 PM: ​
5:33:32 PM:   Error message
5:33:33 PM: Creating deploy upload records
5:33:32 PM:   Command failed with exit code 1: npm run build (https://ntl.fyi/exit-code-1)
5:33:32 PM: ​
5:33:32 PM:   Error location
5:33:32 PM:   In Build command from Netlify app:
5:33:33 PM: Failed during stage 'building site': Build script returned non-zero exit code: 2 (https://ntl.fyi/exit-code-2)
5:33:32 PM:   npm run build
5:33:32 PM: ​
5:33:32 PM:   Resolved config
5:33:32 PM:   build:
5:33:32 PM:     command: npm run build
5:33:32 PM:     commandOrigin: ui
5:33:32 PM:     environment:
5:33:32 PM:       - REVIEW_ID
5:33:32 PM:     publish: /opt/build/repo/build
5:33:32 PM:     publishOrigin: ui

netdata/blog#141

https://app.netlify.com/sites/netdata-blog/deploys/63767045535f680008be2fff

p.s. thanks for giscus its so cool!!!

@lencx
Copy link

lencx commented Nov 20, 2022

Vercel also encountered a similar problem, you can try to modify the tsconfig.json configuration.

{
  // This file is not used in compilation. It is here just for a nice editor experience.
  "extends": "@tsconfig/docusaurus/tsconfig.json",
  "compilerOptions": {
    "jsx": "react-jsx"
  }
}

@laymonage laymonage transferred this issue from giscus/giscus Nov 20, 2022
@laymonage
Copy link
Member

Fixed in #810, released in v2.2.4.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants