Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: sync always omits timeline for left rooms #332

Open
Benjamin-L opened this issue May 3, 2024 · 0 comments
Open

Bug: sync always omits timeline for left rooms #332

Benjamin-L opened this issue May 3, 2024 · 0 comments
Labels
bug Something isn't working core-matrix

Comments

@Benjamin-L
Copy link
Contributor

Steps to reproduce:

  • leave a room
  • issue a /sync request, either without a since parameter or with a since parameter from before the user left the room

The expected result is that the sync response will contain a timeline field for the left room that either has all events between since and the point where the user left the room, or has "limited": true and all events between timeline.prev_batch and the point where the user left the room. The current result is that the timeline field is missing entirely.

Notes

There's an associated TODO comment in the code here.

The code currently does this for left rooms:

Timeline {
	limited: false,
	prev_batch: Some(next_batch_string.clone()),
	events: Vec::new(),
}

If we set limited: true instead, then this would technically be a spec-compliant response, however this ruma bug means that the timeline field will be omitted from the response anyway.

@girlbossceo girlbossceo added bug Something isn't working core-matrix labels May 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working core-matrix
Projects
None yet
Development

No branches or pull requests

2 participants