Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): bump ruby version to 3.2.0 #737

Merged
merged 6 commits into from
Jan 11, 2023
Merged

Conversation

aminedhobb
Copy link
Collaborator

Dans cette PR j'upgrade la version de ruby pour utiliser la version 3.2.0.
J'en ai profité pour update nos gems, notamment rails qui passe à la version 7.4.0 et bundler à la version 2.4.3.
Je fais également quelques modifications de syntaxes liées aux nouvelles règles rubocop introduites par cette version.

@aminedhobb aminedhobb self-assigned this Jan 9, 2023
@aminedhobb aminedhobb changed the title chore(deps): bump to ruby 3.2.0 chore(deps): bump ruby version to 3.2.0 Jan 9, 2023
Holist
Holist previously approved these changes Jan 10, 2023
Copy link
Collaborator

@Holist Holist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool :)

@@ -1,4 +1,4 @@
describe CreateAndInviteApplicantJob, type: :job do
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On a plus besoin de spécifier le type de test dans rspec ?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oui apparemment c'est fait automatiquement maintenant :) !

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

C'est fait automatiquement si on active config.infer_spec_type_from_file_location!. 😉

Ça fait un moment que ça existe (la PR originale pour les curieux), et d'ailleurs il faudrait qu'on parle de ça côté lapins !

@aminedhobb aminedhobb merged commit d0dfce1 into staging Jan 11, 2023
@qblanc qblanc deleted the feat/bump-to-ruby-3.2 branch March 3, 2023 11:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants