Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Breaks other extensions #5

Open
mikkotikkanen opened this issue May 19, 2014 · 4 comments
Open

Breaks other extensions #5

mikkotikkanen opened this issue May 19, 2014 · 4 comments

Comments

@mikkotikkanen
Copy link

When bracket-match-highlighter is installed, I get errors like

file:///C:/Users/user1/AppData/Roaming/Brackets/extensions/lib/codemirror.js

...and...

[Extension] failed to load C:/Users/user1/AppData/Roaming/Brackets/extensions/user/brackets-indentator Error: Script error for: ../../lib/codemirror

Which ends up randomly killing other extensions. I previously reported it to Brackets (adobe/brackets#7782) but now it seems that as long as I don't have highlighter installed, everything's working just fine.

@dnbard
Copy link

dnbard commented Jul 1, 2014

Have the same issue.

@vaughnroyko
Copy link
Contributor

Submitted a pull request to fix this issue. Hopefully it will be approved! Otherwise, you can install from my fork in the meantime, or make the same changes I did to your local file.

@Yobikap
Copy link

Yobikap commented Jul 23, 2014

I've also fixed this issue. But it depends on which version you are running on.

This is my fix:

    function enableHighlighterAddOn(){
        // Enable match-highlighter plugin of CodeMirror2 (this plugin is default contained in sprint 37) 
        if(parseFloat(brackets.metadata.apiVersion) > 0.41){
            var script = document.createElement("script");
            script.src = "thirdparty/CodeMirror2/addon/search/match-highlighter.js";
            document.head.appendChild(script);
        }
    }

@peterflynn
Copy link

@vaughnroyko's fix was merged in PR #6, but @gintau needs to push a new version of the extension onto the registry so users will get the update... I've added a note in the PR about how to do this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants