Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change the color #1

Open
thany opened this issue Feb 19, 2014 · 4 comments
Open

Change the color #1

thany opened this issue Feb 19, 2014 · 4 comments

Comments

@thany
Copy link

thany commented Feb 19, 2014

In my setup, the color that this extension uses for highlights makes them unreadable, not to mention intrusive. It should be subtle.

Suggestion: when the background is dark, the the highlight color to rgba(255,255,255,.2) or something like that. When the background is light, set highlight color to something like rgba(0,0,0,.2).

@gintau
Copy link
Owner

gintau commented Feb 19, 2014

I'd suggest to adjust default.css for the background. The color of background is decided by themes, it's impossible to simply classify whether the background is light or dark, for this extension to decide its highlighting color. Also, custom themes may override

.CodeMirror span.cm-matchhighlight 
for their own colors. My idea is the color should be considered as a part of theme, so I append my default class at the beginning to make custom theme overwrite it.

About the intrusiveness of color. My typical use is to find the usage of certain variables, in this case I'd like to make it obvious enough to easily locate the variables. If this is an issue when editing, I'll try to find a better color for other scenarios under default theme.

@thany
Copy link
Author

thany commented Feb 20, 2014

I can imagine theme plugins not taking into account 3rd (4th?) party plugins. There are so many of them, and many add some visual element that might be styled... Anyway opened a ticket ;)

@juanbodenser
Copy link

I used dark theme of brackets, and when highlighting is white as the letters... So I can't read it.. how to solve this?

@juanbodenser
Copy link

ok I already changed the background color

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants