Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

objcopy doesn't handle ELF section groups #171

Open
philipc opened this issue Dec 29, 2019 · 0 comments
Open

objcopy doesn't handle ELF section groups #171

philipc opened this issue Dec 29, 2019 · 0 comments
Labels

Comments

@philipc
Copy link
Contributor

philipc commented Dec 29, 2019

Untested, but it appears that sections with a type of SHT_GROUP will be parsed as SectionKind::Unknown, and written out with a sh_type set to SHT_PROGBITS.

Even with that fixed, we'll also need to translate the section contents, which contains an array of section indices.

Might be worth auditing objcopy behaviour for all unknown values. It should either read the value as some Unknown variant and then refuse to write it, or preserve the value unchanged.

@philipc philipc added the bug label Dec 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant