php 8.4: Implicitly marking parameter $x as nullable is deprecated, the explicit nullable type must be used instead

[tenzap]

While trying to use your library with php-8.4-rc I have the following deprecation warnings.

Deprecated: libphonenumber\PhoneNumberUtil::getInstance(): Implicitly marking parameter $countryCallingCodeToRegionCodeMap as nullable is deprecated, the explicit nullable type must be used instead in .../vendor/giggsey/libphonenumber-for-php/src/PhoneNumberUtil.php on line 418

Deprecated: libphonenumber\PhoneNumberUtil::getInstance(): Implicitly marking parameter $metadataLoader as nullable is deprecated, the explicit nullable type must be used instead in .../vendor/giggsey/libphonenumber-for-php/src/PhoneNumberUtil.php on line 418

Deprecated: libphonenumber\PhoneNumberUtil::getInstance(): Implicitly marking parameter $metadataSource as nullable is deprecated, the explicit nullable type must be used instead in .../vendor/giggsey/libphonenumber-for-php/src/PhoneNumberUtil.php on line 418

Deprecated: libphonenumber\PhoneNumberUtil::parseAndKeepRawInput(): Implicitly marking parameter $phoneNumber as nullable is deprecated, the explicit nullable type must be used instead in .../vendor/giggsey/libphonenumber-for-php/src/PhoneNumberUtil.php on line 1558

Deprecated: libphonenumber\PhoneNumberUtil::findNumbers(): Implicitly marking parameter $leniency as nullable is deprecated, the explicit nullable type must be used instead in .../vendor/giggsey/libphonenumber-for-php/src/PhoneNumberUtil.php on line 1576

Deprecated: libphonenumber\PhoneNumberUtil::maybeExtractCountryCode(): Implicitly marking parameter $defaultRegionMetadata as nullable is deprecated, the explicit nullable type must be used instead in .../vendor/giggsey/libphonenumber-for-php/src/PhoneNumberUtil.php on line 1959

Deprecated: libphonenumber\PhoneNumberUtil::parse(): Implicitly marking parameter $phoneNumber as nullable is deprecated, the explicit nullable type must be used instead in .../vendor/giggsey/libphonenumber-for-php/src/PhoneNumberUtil.php on line 3103

[tenzap]

Line numbers above are with 8.12.43
Below, it is with 8.13.46

 	
Deprecated: libphonenumber\PhoneNumberUtil::getInstance(): Implicitly marking parameter $countryCallingCodeToRegionCodeMap as nullable is deprecated, the explicit nullable type must be used instead in .../vendor/giggsey/libphonenumber-for-php/src/PhoneNumberUtil.php on line 436

Deprecated: libphonenumber\PhoneNumberUtil::getInstance(): Implicitly marking parameter $metadataLoader as nullable is deprecated, the explicit nullable type must be used instead in .../vendor/giggsey/libphonenumber-for-php/src/PhoneNumberUtil.php on line 436

Deprecated: libphonenumber\PhoneNumberUtil::getInstance(): Implicitly marking parameter $metadataSource as nullable is deprecated, the explicit nullable type must be used instead in .../vendor/giggsey/libphonenumber-for-php/src/PhoneNumberUtil.php on line 436

Deprecated: libphonenumber\PhoneNumberUtil::parseAndKeepRawInput(): Implicitly marking parameter $phoneNumber as nullable is deprecated, the explicit nullable type must be used instead in .../vendor/giggsey/libphonenumber-for-php/src/PhoneNumberUtil.php on line 1595

Deprecated: libphonenumber\PhoneNumberUtil::findNumbers(): Implicitly marking parameter $leniency as nullable is deprecated, the explicit nullable type must be used instead in .../vendor/giggsey/libphonenumber-for-php/src/PhoneNumberUtil.php on line 1613

Deprecated: libphonenumber\PhoneNumberUtil::maybeExtractCountryCode(): Implicitly marking parameter $defaultRegionMetadata as nullable is deprecated, the explicit nullable type must be used instead in .../vendor/giggsey/libphonenumber-for-php/src/PhoneNumberUtil.php on line 2050

Deprecated: libphonenumber\PhoneNumberUtil::parse(): Implicitly marking parameter $phoneNumber as nullable is deprecated, the explicit nullable type must be used instead in .../vendor/giggsey/libphonenumber-for-php/src/PhoneNumberUtil.php on line 3191

[giggsey]

Thanks. Now that PHP 8.4 is in RC, I'll add it to the pipeline here, and get any issues sorted.

Just looking at this error, this might be tricky, as we can't use the nullable type with PHP 5.

Now might be the time to drop older PHP versions

[giggsey]

7.4 is now the minimum version, which allows us to do the necessary stuff for this.

However, the pipeline for 8.4 isn't reporting any issues? https://github.com/giggsey/libphonenumber-for-php/actions/runs/11179907839/job/31080518166

[tenzap]

The issue was not revealed with your test suite actually.

[giggsey]

Can you share how the deprecations were displayed? PHPUnit has (now) been configured to convert deprecations to exceptions, but the pipeline is running 8.4-dev, so maybe it's not on the correct release yet.

[tenzap]

Some calls to your lib:

https://github.com/kalkun-sms/Kalkun/blob/v0.8.2.1/application/views/main/settings/general.php#L17
https://github.com/kalkun-sms/Kalkun/blob/v0.8.2.1/application/helpers/kalkun_helper.php#L369
https://github.com/kalkun-sms/Kalkun/blob/v0.8.2.1/application/helpers/kalkun_helper.php#L391
https://github.com/kalkun-sms/Kalkun/blob/v0.8.2.1/application/helpers/kalkun_helper.php#L428

[giggsey]

Thanks.

I can see the issue on the lite project: https://github.com/giggsey/libphonenumber-for-php-lite/actions/runs/11231376835/job/31220687096?pr=73

[giggsey]

This should now be fixed with the latest version. When running 8.4-rc via Docker locally, I was able to find the errors