Skip to content

Commit 5b708ad

Browse files
committed
Add tests for Node.js version 21
1 parent c99283d commit 5b708ad

File tree

3 files changed

+6
-6
lines changed

3 files changed

+6
-6
lines changed

.devcontainer/Dockerfile

+2-2
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,6 @@ RUN echo $USERNAME ALL=\(root\) NOPASSWD:ALL > /etc/sudoers.d/$USERNAME \
1414
&& chmod 0440 /etc/sudoers.d/$USERNAME
1515
USER $USERNAME
1616
RUN curl -o- https://raw.githubusercontent.com/nvm-sh/nvm/v0.39.2/install.sh | bash
17-
RUN [ "/bin/bash", "-c", "source $HOME/.nvm/nvm.sh && nvm i --no-progress 18.18.0 && nvm i --no-progress 20.7.0" ]
18-
RUN [ "/bin/bash", "-c", "source $HOME/.nvm/nvm.sh && nvm alias default 20" ]
17+
RUN [ "/bin/bash", "-c", "source $HOME/.nvm/nvm.sh && nvm i --no-progress 18.18.0 && nvm i --no-progress 20.7.0 && nvm i --no-progress 21.1.0" ]
18+
RUN [ "/bin/bash", "-c", "source $HOME/.nvm/nvm.sh && nvm alias default 21" ]
1919
ENV DEBIAN_FRONTEND=dialog

.github/workflows/build.yml

+3-3
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@ jobs:
3636
strategy:
3737
fail-fast: false
3838
matrix:
39-
node: ["18.x", "20.x"]
39+
node: ["18.x", "20.x", "21.x"]
4040
runner: ["windows-latest", "ubuntu-latest", "macos-latest"]
4141
steps:
4242
- uses: actions/checkout@v4
@@ -72,7 +72,7 @@ jobs:
7272
strategy:
7373
fail-fast: false
7474
matrix:
75-
node: ["18", "20"]
75+
node: ["18", "20", "21"]
7676
steps:
7777
- uses: actions/checkout@v4
7878
- uses: uraimo/[email protected]
@@ -116,7 +116,7 @@ jobs:
116116
strategy:
117117
fail-fast: false
118118
matrix:
119-
node: ["18", "20"]
119+
node: ["18", "20", "21"]
120120
steps:
121121
- uses: actions/checkout@v4
122122
- uses: uraimo/[email protected]

testInstall.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ const os = require('os');
66
const path = require('path');
77
const fs = require('fs');
88
const spawnSync = require('child_process').spawnSync;
9-
const versions = ['18', '20'];
9+
const versions = ['18', '20', '21'];
1010
const tempInstallPath = path.resolve(os.tmpdir(), 'chromedriver-test');
1111
const packedFile = path.resolve(tempInstallPath, 'chromedriver.tgz');
1212

0 commit comments

Comments
 (0)