Skip to content

fix test in delete app config #4693

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pipo02mix merged 2 commits into from
Jan 20, 2026
Merged

fix test in delete app config #4693

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
07a874a
fix test in delete app config
pipo02mix Jan 9, 2026
bf70e45
Merge branch 'main' into fix-test-error-ui
pipo02mix Jan 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 25 additions & 3 deletions src/components/Cluster/ClusterDetail/AppDetailsModal/AppDetailsModal.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -110,30 +110,52 @@ const AppDetailsModal: React.FC<
async function deleteAppConfig() {
try {
await dispatch(deleteAppConfigAction(appName, clusterId));
} catch (err) {
// Keep going; the thunk action does its own user-facing error handling.
ErrorReporter.getInstance().notify(err as Error);
}

try {
await dispatch(loadClusterApps({ clusterId: clusterId }));
handleClose();
} catch (err) {
// Don't keep the modal stuck open just because refreshing failed.
ErrorReporter.getInstance().notify(err as Error);
} finally {
handleClose();
}
}

async function deleteAppSecret() {
try {
await dispatch(deleteAppSecretAction(appName, clusterId));
} catch (err) {
// Keep going; the thunk action does its own user-facing error handling.
ErrorReporter.getInstance().notify(err as Error);
}

try {
await dispatch(loadClusterApps({ clusterId: clusterId }));
handleClose();
} catch (err) {
// Don't keep the modal stuck open just because refreshing failed.
ErrorReporter.getInstance().notify(err as Error);
} finally {
handleClose();
}
}

async function deleteApp() {
try {
await dispatch(deleteAppAction({ appName, clusterId }));
} catch (err) {
ErrorReporter.getInstance().notify(err as Error);
}

try {
await dispatch(loadClusterApps({ clusterId: clusterId }));
handleClose();
} catch (err) {
ErrorReporter.getInstance().notify(err as Error);
} finally {
handleClose();
}
}

Expand Down