Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make ECR permissions configurable #365

Closed
puja108 opened this issue Aug 1, 2017 · 1 comment
Closed

Make ECR permissions configurable #365

puja108 opened this issue Aug 1, 2017 · 1 comment

Comments

@puja108
Copy link
Member

puja108 commented Aug 1, 2017

As for #364 we have ECR permission in our EC2 instance policy, however, there might be use cases, where only certain clusters should have access to ECR and others not. For this we need to make the addition of the ECR policy configurable.

ping @rossf7

@rossf7
Copy link
Contributor

rossf7 commented Apr 9, 2018

Closing. We added the ECR permissions a long time ago and we've had no requirement to make them configurable.

This is not difficult to do but it's more configuration to manage. If we do it at the installation level it causes a difference in config between installs. Doing it at the cluster level means we'd need to add it to the API.

cc @xh3b4sd @puja108

Please reopen if you disagree.

@rossf7 rossf7 closed this as completed Apr 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants