Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ruff Python linter, remove flake8 #2312

Merged
merged 51 commits into from
Oct 4, 2023
Merged

Add ruff Python linter, remove flake8 #2312

merged 51 commits into from
Oct 4, 2023

Conversation

giampaolo
Copy link
Owner

See: https://blog.jerrycodes.com/ruff-the-python-linter/. Advantages:

  1. an order of magnitude faster than flake8 + isort (0.1 secs instead of 2.5 secs to lint all .py files):

Before:

$ time make flake8 isort 
real	0m2,554s
user	0m15,626s
sys	0m0,436s

Now:

$ time make ruff 
real	0m0,102s
user	0m0,297s
sys	0m0,025s
  1. A lot more code quality checks than before.

Previously done also for pyftpdlib: giampaolo/pyftpdlib#611.

@giampaolo
git pre commit: rm checks of py files content
077225d 
Signed-off-by: Giampaolo Rodola <[email protected]>
@giampaolo
merge from master
bb4c12b
@giampaolo
get rid of flake8 (woha!)
31411ba
@giampaolo
add ruff config (taken from pyftpdlib)
b8f19dc
@giampaolo
run fixer for unnecessary parentheses
7604a18
@giampaolo
run fixer for unnecessary open(..., mode) param
6208d91
@giampaolo
run fixer for unnecessary u'...' literal
0877060
@giampaolo
run fixer for unnecessary inheritance from (object)
103b0c0
@giampaolo
add fixes
f0265eb
@giampaolo
run fixer for ternary operator
48825bd
@giampaolo
run fixer for use unpack tuple comprehension instead of list
a410b08
@giampaolo
run anoter fixer
df059d0
@giampaolo
fix eval()
82a76fd
@giampaolo
run anoter fixer
94cda62
@giampaolo
run another fixer
c167bdc
@giampaolo
run another fixer
1ac91b7
@giampaolo
run another fixer
c6ac87c
@giampaolo
run another fixer
6c38c3b
@giampaolo
fix str formatting
d67ff0f
@giampaolo
run another fixer
718d148
@giampaolo
run another fixer
72c2540
@giampaolo
run another fixer
1adf92d
@giampaolo
fix str format
5315b34
@giampaolo
run another fixer
52db13d
@giampaolo
run another fixer
92f1f6b
@giampaolo
run another fixer
0447fe6
@giampaolo
run another fixer
adf6449
@giampaolo
run another fixer
770fb50
@giampaolo
run another fixer
793ae88
@giampaolo
run another fixer
c9805e5
@giampaolo giampaolo merged commit 84cdeb4 into master Oct 4, 2023
19 of 23 checks passed
@giampaolo giampaolo deleted the ruff branch October 4, 2023 12:46
ddelange added a commit to ddelange/psutil that referenced this pull request Oct 16, 2023
@ddelange
Merge branch 'master' of https://github.com/giampaolo/psutil
e6e50c1 
* 'master' of https://github.com/giampaolo/psutil:
  pre-release
  give CREDIT to @JeremyGrosser and @getsentry for sponsorship (thanks\!)
  fix error in test_contracts.py on win
  chore: update GHA workflows (giampaolo#2315)
  fix giampaolo#2195 / linux: no longer print exception at import time
  Add ruff Python linter, remove flake8 (giampaolo#2312)
  Add toml-sort linting tool for pyproject.toml (giampaolo#2311)
  new RTD config
  new RTD config
  new RTD config
  Fix giampaolo#2308, OpenBSD: Process.threads() always fail with AccessDenied.
  Win: fix OpenProcess not recognizing when proc is gone.
  refact assertProcessGone
  refact assertProcessGone
  Add RsT linter (giampaolo#2292)
  Make _raise_if_pid_reused() raise NSP only if pid has been reused.
  fix DEVGUIDE.rst
  PID reusage is not checked for different set methods (giampaolo#2291)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@giampaolo