Fix read violation crash in psutil.cpu_count(logical=False) #1480
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous code would read one item off the end because
offset
equalslength
for the last element, but the code only checks thatoffset + ptr->Size <= length
at the top of the iteration, which means it would always dereferenceptr->Size
whereptr
points to memory that wasn't allocated tobuffer
. That occasionally causes read violation crashes.ptr->Size > 0
check because the struct size should never be 0 or something terribly wrong has happened.To repro the crash, I did the following in cmd.exe: