Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transparency in quick terminal #2331

Closed
lucymhdavies opened this issue Sep 30, 2024 · 2 comments · Fixed by #2343
Closed

Transparency in quick terminal #2331

lucymhdavies opened this issue Sep 30, 2024 · 2 comments · Fixed by #2343
Labels

Comments

@lucymhdavies
Copy link
Contributor

#2320 is great!

Currently, background-opacity doesn't apply to the quick terminal window.

My initial thinking here is that users may want to configure background opacity for normal windows separately from quick terminal. There's a couple of options I can think of for how we may want to do this:

  • introducing a new config item just for quick terminal, and ignoring the main background-opacity entirely
  • using the background-opacity setting by default, and then introducing a separate config item to override it

I don't actually know which makes the most sense.

@mitchellh
Copy link
Contributor

Fixed in #2343. I opted for now to share a configuration between all. I think applying a quick-terminal-specific opacity could be interesting but I want to avoid config sprawl until there is a critical mass of requests for that.

@lucymhdavies
Copy link
Contributor Author

Sounds good, and a pragmatic approach :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants