Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draw underlines and undercurls beneath glyphs and break around glyphs #2061

Open
net opened this issue Aug 7, 2024 · 1 comment
Open

Draw underlines and undercurls beneath glyphs and break around glyphs #2061

net opened this issue Aug 7, 2024 · 1 comment
Labels

Comments

@net
Copy link

net commented Aug 7, 2024

Some modern rendering systems draw underlines underneath glyphs, and interrupt them to keep it from touching glyphs.

macOS:
Screenshot 2024-08-07 at 16 26 58

Chromium:
Screenshot 2024-08-07 at 16 25 25 Screenshot 2024-08-07 at 16 25 04

This serves both an aesthetic and legibility purpose: it's easier to decipher glyphs when they're not colliding with or obscured by an underline.

This undercurl drawn by Ghostty is trying to indicate an error with the text _foo, but the undercurl obscures the _:
Screenshot 2024-08-07 at 16 34 18

It would be great if Ghostty used the interrupted style of underlining for underlines and undercurls. ❤️

@lithammer
Copy link

Worth noting is that iTerm2 is doing this as well.

Image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants