Rationalize the flow of configuration updates. #5947
Unanswered
jcollie
asked this question in
Feature Requests, Ideas
Replies: 0 comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
-
Right now when a configuration reload is triggered, the core App sends a
change_config
message to every apprt Surface.ghostty/src/App.zig
Lines 145 to 148 in 3f715c2
On GTK, Windows will have their
updateConfig
methods called multiple times (once for every surface contained in the window):ghostty/src/apprt/gtk/App.zig
Lines 907 to 912 in 3f715c2
This has not been a problem so far, but with trying to do more in the GTK apprt with the DerivedConfig model it could cause problems with extra allocs/deallocs, extra copying, and extra work by GTK as it processes the repeated changes.
The flow of configuration reloads should be rationalized so that duplicate work is not being done.
Beta Was this translation helpful? Give feedback.
All reactions