Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(export): fix negative number exports to Excel #977

Merged
merged 1 commit into from
May 19, 2023

Conversation

ghiscoding
Copy link
Owner

- fixes an issue identified in Angular-Slickgrid where the negative numbers were seeing negative numbers turned to positive numbers (ref: ghiscoding/Angular-Slickgrid#1135)
- also improve perf of `exportWithFormatterWhenDefined` by analyzing `exportWithFormatter` only once instead of twice
@ghiscoding ghiscoding merged commit edf5721 into master May 19, 2023
@ghiscoding ghiscoding deleted the bugfix/excel-export-negative-numbers branch May 19, 2023 23:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant