feat(build): move TypeScript types into a single dist/types folder #905
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- also remove browser, I don't think it's needed anymore since breakpoints are working fine now that we're exporting the main as ESM
- prior to this PR, TS Types were added to both CJS/ESM folders, but 1 common dist/types folder is easier to find and will lower our published build size by a lot
Codecov Report
@@ Coverage Diff @@
## master #905 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 244 244
Lines 16595 16595
Branches 5907 5907
=========================================
Hits 16595 16595 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
ghiscoding
changed the title
ghiscoding
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.