Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(addons): do not add special columns twice (like Row Selection) #822

Merged
merged 1 commit into from
Nov 29, 2022

Conversation

ghiscoding
Copy link
Owner

  • some addons are adding special columns dynamically (Row Move, Row Detail & Row Selection) and in rare occasion it could end up adding the same special column multiple time

- some addons are adding special columns dynamically (Row Move, Row Detail & Row Selection) and in rare occasion it could end up adding the same special column multiple time
@codecov
Copy link

codecov bot commented Nov 29, 2022

Codecov Report

Merging #822 (8572dfb) into master (60e4a29) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##            master      #822   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          239       239           
  Lines        16363     16366    +3     
  Branches      5547      5547           
=========================================
+ Hits         16363     16366    +3     
Impacted Files Coverage Δ
...common/src/extensions/slickCheckboxSelectColumn.ts 100.00% <100.00%> (ø)
...kages/common/src/extensions/slickRowMoveManager.ts 100.00% <100.00%> (ø)
...s/row-detail-view-plugin/src/slickRowDetailView.ts 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@ghiscoding ghiscoding merged commit a80d6f8 into master Nov 29, 2022
@ghiscoding ghiscoding deleted the bugfix/multiple-row-selection-checkbox-columns branch November 29, 2022 05:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant