Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(plugin): do not show drag group sort when column is not sortable #819

Merged
merged 1 commit into from
Nov 17, 2022

Conversation

ghiscoding
Copy link
Owner

@ghiscoding ghiscoding commented Nov 17, 2022

  • recent feature to add sort icon in SlickDraggableGrouping did not look at the possibility that the column itself might not be sortable, however it has to be considered

for example, below we can see that the "Market" column is not sortable and should not have the sort icon in the preheader group
image

- recent feature to add sort icon in SlickDraggableGrouping did not look at the possibility that the column itself might not be `sortable`, however it has to be considered
@codecov
Copy link

codecov bot commented Nov 17, 2022

Codecov Report

Merging #819 (d546357) into master (80c6508) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##            master      #819   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          239       239           
  Lines        16365     16366    +1     
  Branches      5547      5547           
=========================================
+ Hits         16365     16366    +1     
Impacted Files Coverage Δ
packages/common/src/editors/editors.index.ts 100.00% <ø> (ø)
...es/common/src/extensions/slickDraggableGrouping.ts 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@ghiscoding ghiscoding merged commit 049303b into master Nov 17, 2022
@ghiscoding ghiscoding deleted the bugfix/draggable-grouping-without-sortable branch November 17, 2022 19:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant