Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(common): changing Slider value(s) should update Tooltip instantly #800

Merged
merged 5 commits into from
Nov 10, 2022

Conversation

ghiscoding
Copy link
Owner

  • when dragging slider to a new value, it should update the tooltip (when using SlickCustomTooltip plugin) on the fly while dragging, that is whenever the Slider value changes it should reflect the new value instantly on the tooltip as well

brave_iw9CZAmJPx

- when dragging slider to a new value, it should update the tooltip (when using SlickCustomTooltip plugin) on the fly while dragging, that is whenever the Slider value changes it should reflect the new value instantly on the tooltip as well
@codecov
Copy link

codecov bot commented Nov 9, 2022

Codecov Report

Merging #800 (92b34f7) into master (a3c8b6e) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##            master      #800   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          237       237           
  Lines        16454     16460    +6     
  Branches      5548      5552    +4     
=========================================
+ Hits         16454     16460    +6     
Impacted Files Coverage Δ
packages/common/src/editors/sliderEditor.ts 100.00% <100.00%> (ø)
packages/common/src/filters/sliderFilter.ts 100.00% <100.00%> (ø)
...es/custom-tooltip-plugin/src/slickCustomTooltip.ts 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

- if we're not a slick-cell div, we should not be able to execute `grid.getCellFromEvent(event)` in the SlickCustomTooltip plugin
@ghiscoding ghiscoding changed the title fix(common): changing Slider value(s) should update Tooltip in sync fix(common): changing Slider value(s) should update Tooltip instantly Nov 9, 2022
@ghiscoding ghiscoding merged commit 9c6be27 into master Nov 10, 2022
@ghiscoding ghiscoding deleted the bugfix/slider-tooltip-update-while-dragging branch November 10, 2022 01:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant