Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(editors): Slider editor track not showing after Slider filter change #792

Merged
merged 1 commit into from
Nov 5, 2022

Conversation

ghiscoding
Copy link
Owner

  • after merging all Slider filters and changing all its styling, the Slider editor also needs to be updated to use same code
  • this PR also adds the slider track filling color that previous Slider filter PR brought

@codecov
Copy link

codecov bot commented Nov 5, 2022

Codecov Report

Merging #792 (a2b7a39) into master (fc4304b) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##            master      #792   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          236       236           
  Lines        16402     16434   +32     
  Branches      5525      5538   +13     
=========================================
+ Hits         16402     16434   +32     
Impacted Files Coverage Δ
packages/common/src/editors/sliderEditor.ts 100.00% <100.00%> (ø)
packages/common/src/filters/sliderFilter.ts 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@ghiscoding ghiscoding merged commit 2ad02d2 into master Nov 5, 2022
@ghiscoding ghiscoding deleted the bugfix/slider-editor-styling-change branch November 5, 2022 00:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant