Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(footer): add Custom Footer component #5

Merged
merged 11 commits into from
Jul 9, 2020
Merged

Conversation

ghiscoding
Copy link
Owner

No description provided.

@codecov
Copy link

codecov bot commented Jul 1, 2020

Codecov Report

Merging #5 into master will increase coverage by 0.55%.
The diff coverage is 95.62%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master       #5      +/-   ##
==========================================
+ Coverage   94.85%   95.39%   +0.55%     
==========================================
  Files         183      183              
  Lines        9710     9760      +50     
  Branches     3219     3325     +106     
==========================================
+ Hits         9209     9310     +101     
+ Misses        501      450      -51     
Impacted Files Coverage Δ
packages/vanilla-bundle/src/services/index.ts 100.00% <ø> (ø)
packages/vanilla-bundle/src/vanilla-grid-bundle.ts 3.44% <16.67%> (+0.05%) ⬆️
...ages/vanilla-bundle/src/components/slick-footer.ts 100.00% <100.00%> (ø)
.../vanilla-bundle/src/components/slick-pagination.ts 100.00% <100.00%> (ø)
...ages/vanilla-bundle/src/services/binding.helper.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fe014ca...cf6970a. Read the comment docs.

@ghiscoding ghiscoding changed the title WIP - feat(footer): add Custom Footer component feat(footer): add Custom Footer component Jul 2, 2020
@ghiscoding ghiscoding merged commit 59d0ba8 into master Jul 9, 2020
@ghiscoding ghiscoding deleted the feat/custom-footer branch July 9, 2020 12:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants