refactor: add 10ms delay on 1st resize so it's after grid render #462
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
ghiscoding
commented
Sep 1, 2021
ghiscoding
commented
- hopefully helps in fixing blank data shown in Angular-Slickgrid
…ender - hopefully helps in fixing blank data shown in Angular-Slickgrid
Codecov Report
@@ Coverage Diff @@
## master #462 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 220 220
Lines 13491 13491
Branches 4426 4426
=========================================
Hits 13491 13491
Continue to review full report at Codecov.
|
ghiscoding-SE
pushed a commit
that referenced
this pull request
Sep 8, 2021
- the previous PR #462 which added a delay in the grid resize actually introduced a regression in Salesforce, the hack which looks for a resize every few ms wasn't registered at all anymore because of the new delay. So let's put back the way it was before and and also add a 2nd one with the delay required by Angular-Slickgrid
ghiscoding
added a commit
that referenced
this pull request
Sep 8, 2021
…force fix(resizer): regression introduced by #462 for the grid resize in SF
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.