Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(pinning): add "Freezen Columns" to header menu #4

Merged
merged 4 commits into from
Jun 12, 2020

Conversation

ghiscoding
Copy link
Owner

@ghiscoding ghiscoding commented Jun 11, 2020

  • this feature will basically allow the user to freeze all columns until the current position of the column header he opened. For example if user is opening column 4 header menu and click on "Frozen Columns", it will freeze all 4 columns on the left.

  • requires PR #513 on core lib to be merged and released

AGrRe27eQZ

- this feature will basically allow the user to freeze all columns until the current position of the column header he opened. For example if user is opening column 4 header menu and click on "Frozen Columns", it will freeze all 4 columns on the left.
@codecov
Copy link

codecov bot commented Jun 11, 2020

Codecov Report

Merging #4 into master will decrease coverage by 0.11%.
The diff coverage is 65.63%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master       #4      +/-   ##
==========================================
- Coverage   94.74%   94.63%   -0.10%     
==========================================
  Files         171      171              
  Lines        8661     8708      +47     
  Branches     2946     2868      -78     
==========================================
+ Hits         8205     8240      +35     
- Misses        456      468      +12     
Impacted Files Coverage Δ
packages/common/src/constants.ts 100.00% <ø> (ø)
...vanilla-bundle/src/services/eventPubSub.service.ts 0.00% <0.00%> (ø)
packages/vanilla-bundle/src/vanilla-grid-bundle.ts 0.00% <0.00%> (ø)
...ges/common/src/extensions/columnPickerExtension.ts 100.00% <100.00%> (ø)
...ackages/common/src/extensions/gridMenuExtension.ts 100.00% <100.00%> (ø)
...kages/common/src/extensions/headerMenuExtension.ts 100.00% <100.00%> (ø)
.../common/src/services/groupingAndColspan.service.ts 100.00% <100.00%> (ø)
packages/common/src/services/pubSub.service.ts 100.00% <100.00%> (ø)
packages/common/src/services/shared.service.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c121b8f...1b9808b. Read the comment docs.

@ghiscoding ghiscoding changed the title WIP - feat(pinning): add "Frozen Columns" to header menu feat(pinning): add "Frozen Columns" to header menu Jun 12, 2020
@ghiscoding ghiscoding changed the title feat(pinning): add "Frozen Columns" to header menu feat(pinning): add "Freezen Columns" to header menu Jun 12, 2020
@ghiscoding ghiscoding merged commit 1c7d49f into master Jun 12, 2020
@ghiscoding ghiscoding deleted the feat/pin-to-left-header-menu branch June 12, 2020 19:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants