feat(filters): display operator into input text filter from Grid Presets #288
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- a use case that we have with the text InputFilter is that if have a filter that includes an operator inside the search text (e.g.: ">=55") and we save the Grid State in Local Storage or anything else and then we reload them as Grid Presets, the operator won't be showing up (it would only show "55" while keeping the Operator hidden but still in play) that is because the FilterService is doing the split (this is an Operator and these are the SearchTerm) and the Grid State only keeps the split, so in that case this PR adds an extra step that if we're using the `setValues()` method, then we're probably using a Grid Preset or an UpdateFilters and we should display the operator as part of the final displayed search string inside the input value
Codecov Report
@@ Coverage Diff @@
## master #288 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 209 209
Lines 12436 12467 +31
Branches 4254 4269 +15
=========================================
+ Hits 12436 12467 +31
Continue to review full report at Codecov.
|
ghiscoding
deleted the
feat/grid-presets-display-operator-in-search-string
branch
ghiscoding
added a commit
that referenced
this pull request
Mar 23, 2021
- rolling back this change since Aurelia-Slickgrid filter presets on Client Example was no longer working as expected
ghiscoding
added a commit
that referenced
this pull request
Mar 23, 2021
fix(filters): rollback a change made in PR #288 causing preset issues
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
setValues()method, then we're probably using a Grid Preset or an UpdateFilters and we should display the operator as part of the final displayed search string inside the input value