Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(components): both Footer/Pagination should always be 100% width #27

Merged
merged 3 commits into from
Jul 24, 2020

Conversation

ghiscoding
Copy link
Owner

@ghiscoding ghiscoding commented Jul 24, 2020

  • assuming that our grid container contains the grid and/or a footer/pagination then this container has to be resized at the same time as the grid and it has to be the exact same size
  • this fixes an issue that was showing up when adding rightPadding to the autoResize options. The width of the footer/pagination was always wrong and this PR fixes this issue.

@codecov
Copy link

codecov bot commented Jul 24, 2020

Codecov Report

Merging #27 into master will decrease coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #27      +/-   ##
==========================================
- Coverage   99.56%   99.56%   -0.00%     
==========================================
  Files         183      183              
  Lines        9978     9968      -10     
  Branches     3291     3393     +102     
==========================================
- Hits         9934     9924      -10     
  Misses         44       44              
Impacted Files Coverage Δ
...ages/vanilla-bundle/src/components/slick-footer.ts 100.00% <100.00%> (ø)
.../vanilla-bundle/src/components/slick-pagination.ts 100.00% <100.00%> (ø)
...bundle/src/components/slick-vanilla-grid-bundle.ts 92.44% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6292f26...0bbccc0. Read the comment docs.

@ghiscoding ghiscoding merged commit e587ef5 into master Jul 24, 2020
@ghiscoding ghiscoding deleted the bugfix/footer-pagination-resize branch July 24, 2020 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants