Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core): add Translation into demo with fetch locale from json file #23

Merged
merged 11 commits into from
Jul 22, 2020

Conversation

ghiscoding
Copy link
Owner

@ghiscoding ghiscoding commented Jul 21, 2020

TODO

  • Add a TranslationService which will use the Fetch API
  • Add Translation into at least 1 demo page (Example 10)
  • Slick Pagination has 2 texts "of" but only one get translated
  • Possibly pass a Global Event Service instance (same as Aurelia) that could be passed by the Demo!?
    • or add an directly into the Translate Service that slick-vanilla-bundle can directly subscribe to
  • add Unit Tests
  • add Cypress E2E tests

@ghiscoding ghiscoding changed the title feat(core): add Translation into demo with fetch locale from json file WIP - feat(core): add Translation into demo with fetch locale from json file Jul 22, 2020
@ghiscoding ghiscoding mentioned this pull request Jul 22, 2020
@codecov
Copy link

codecov bot commented Jul 22, 2020

Codecov Report

Merging #23 into master will decrease coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #23      +/-   ##
==========================================
- Coverage   99.58%   99.58%   -0.00%     
==========================================
  Files         184      183       -1     
  Lines        9982     9967      -15     
  Branches     3398     3277     -121     
==========================================
- Hits         9940     9925      -15     
  Misses         42       42              
Impacted Files Coverage Δ
packages/vanilla-bundle/src/services/index.ts 100.00% <ø> (ø)
packages/common/src/editors/dateEditor.ts 100.00% <100.00%> (ø)
packages/common/src/editors/longTextEditor.ts 100.00% <100.00%> (ø)
packages/common/src/editors/selectEditor.ts 100.00% <100.00%> (ø)
...ackages/common/src/extensions/cellMenuExtension.ts 100.00% <100.00%> (ø)
...ages/common/src/extensions/contextMenuExtension.ts 100.00% <100.00%> (ø)
packages/common/src/extensions/extensionUtility.ts 100.00% <100.00%> (ø)
...ackages/common/src/extensions/gridMenuExtension.ts 100.00% <100.00%> (ø)
...kages/common/src/extensions/headerMenuExtension.ts 100.00% <100.00%> (ø)
packages/common/src/filters/compoundDateFilter.ts 100.00% <100.00%> (ø)
... and 14 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1132f2e...67481c9. Read the comment docs.

ghiscoding and others added 9 commits July 21, 2020 23:00
- with this new method, the slick-vanilla bundle will use the new method to add it's own internal pub/sub service to it and whenever the language changes will then triggered necessary subscription(s)
- prior to this change, it was working with only the last element defined
- for example, slick pagination has 2 "text-of" elements which should be both binded to the same variable, if that variable changes, it should update both elements found in the DOM, but prior to the fix only the last one was working
@ghiscoding ghiscoding changed the title WIP - feat(core): add Translation into demo with fetch locale from json file feat(core): add Translation into demo with fetch locale from json file Jul 22, 2020
@ghiscoding ghiscoding merged commit b5608e9 into master Jul 22, 2020
@ghiscoding ghiscoding deleted the feat/translate-locales branch July 22, 2020 22:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants