Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): use regular imports instead of require to load plugins #209

Merged
merged 2 commits into from
Dec 22, 2020

Conversation

ghiscoding
Copy link
Owner

@ghiscoding ghiscoding commented Dec 21, 2020

  • this also fixes RequireJS missing plugin imports with ESM Module
  • replace all require(plugin) since that is not tree shakable and imports are

@codecov
Copy link

codecov bot commented Dec 22, 2020

Codecov Report

Merging #209 (19a0873) into master (3b3b463) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##            master      #209    +/-   ##
==========================================
  Coverage   100.00%   100.00%            
==========================================
  Files          207       207            
  Lines        11904     11847    -57     
  Branches      3916      4053   +137     
==========================================
- Hits         11904     11847    -57     
Impacted Files Coverage Δ
packages/common/src/extensions/extensionUtility.ts 100.00% <ø> (ø)
...ages/common/src/extensions/autoTooltipExtension.ts 100.00% <100.00%> (ø)
...src/extensions/cellExternalCopyManagerExtension.ts 100.00% <100.00%> (ø)
...ackages/common/src/extensions/cellMenuExtension.ts 100.00% <100.00%> (ø)
...common/src/extensions/checkboxSelectorExtension.ts 100.00% <100.00%> (ø)
...ges/common/src/extensions/columnPickerExtension.ts 100.00% <100.00%> (ø)
...ages/common/src/extensions/contextMenuExtension.ts 100.00% <100.00%> (ø)
...ommon/src/extensions/draggableGroupingExtension.ts 100.00% <100.00%> (ø)
...ackages/common/src/extensions/gridMenuExtension.ts 100.00% <100.00%> (ø)
...ges/common/src/extensions/headerButtonExtension.ts 100.00% <100.00%> (ø)
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3b3b463...19a0873. Read the comment docs.

@ghiscoding ghiscoding merged commit 6816696 into master Dec 22, 2020
@ghiscoding ghiscoding deleted the bugfix/remove-dynamically-load-plugins branch December 22, 2020 02:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant