Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core): add enableMouseWheelScrollHandler grid option #170

Merged
merged 3 commits into from
Dec 2, 2020

Conversation

ghiscoding
Copy link
Owner

@ghiscoding ghiscoding commented Nov 25, 2020

  • this enables the use of the mousewheel scrolling event handler and that makes the mousewheel scroll to work from anywhere in the grid
  • requires the core lib PR #555 to be merged and released

- this enables the use of the mousewheel scrolling event handler and that makes the mousewheel scroll to work from anywhere in the grid
@codecov
Copy link

codecov bot commented Nov 25, 2020

Codecov Report

Merging #170 (5104e51) into master (2a812ed) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##            master      #170    +/-   ##
==========================================
  Coverage   100.00%   100.00%            
==========================================
  Files          202       202            
  Lines        11743     11741     -2     
  Branches      3856      4003   +147     
==========================================
- Hits         11743     11741     -2     
Impacted Files Coverage Δ
...ackages/common/src/extensions/gridMenuExtension.ts 100.00% <100.00%> (ø)
...kages/common/src/extensions/headerMenuExtension.ts 100.00% <100.00%> (ø)
...bundle/src/components/slick-vanilla-grid-bundle.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2a812ed...5104e51. Read the comment docs.

@ghiscoding ghiscoding changed the title feat(core): add enableMouseWheelScrollHandler grid option WIP - feat(core): add enableMouseWheelScrollHandler grid option Nov 25, 2020
@ghiscoding ghiscoding changed the title WIP - feat(core): add enableMouseWheelScrollHandler grid option feat(core): add enableMouseWheelScrollHandler grid option Dec 2, 2020
@ghiscoding ghiscoding merged commit 53598d9 into master Dec 2, 2020
@ghiscoding ghiscoding deleted the feat/mousewheel-scroll-only-frozen-grid branch December 2, 2020 19:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant