Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(services): add 2x new methods hideColumnById or ..byIds #160

Merged
merged 3 commits into from
Nov 17, 2020

Conversation

ghiscoding
Copy link
Owner

  • deprecate previous methods (hideColumn, hideColumnByIndex) since the new methods offer more values with extra options to resize and/or hide from pickers

Ghislain Beaulac added 3 commits November 17, 2020 10:30
- deprecate previous methods (hideColumn, hideColumnByIndex) since the new methods offer more values with extra options to resize and/or hide from pickers
@codecov
Copy link

codecov bot commented Nov 17, 2020

Codecov Report

Merging #160 (c5dd2be) into master (1012cfb) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##            master      #160    +/-   ##
==========================================
  Coverage   100.00%   100.00%            
==========================================
  Files          198       198            
  Lines        11635     11667    +32     
  Branches      3971      3835   -136     
==========================================
+ Hits         11635     11667    +32     
Impacted Files Coverage Δ
packages/common/src/interfaces/index.ts 100.00% <100.00%> (ø)
packages/common/src/services/grid.service.ts 100.00% <100.00%> (ø)
...bundle/src/components/slick-vanilla-grid-bundle.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1012cfb...c5dd2be. Read the comment docs.

@ghiscoding ghiscoding merged commit d396653 into master Nov 17, 2020
@ghiscoding ghiscoding deleted the feat/grid-service-hide-column-by-ids branch November 17, 2020 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant