fix(editor): Composite Editor should work with Cell Menu #1591
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- by default Cell Menu are preventing event bubbling and this causes the Cell Menu to not activate the active cell and this causes the Composite Editor to not receive the correct row number, let's add a `cellMenu.preventEventBubbling` to keep the default but offer the option to disable the default and fix Composite Editor
|
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1591 +/- ##
======================================
Coverage 99.8% 99.8%
======================================
Files 198 198
Lines 21793 21793
Branches 7020 7020
======================================
Hits 21732 21732
Misses 61 61 ☔ View full report in Codecov by Sentry. |
ghiscoding
added a commit
that referenced
this pull request
Jul 3, 2024
- this rename the new Cell Menu option introduced in previous PR #1591 to fix Composite Editor Cell Menu not using correct row index
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cellMenu.preventEventBubblingto keep the default but offer the option to disable the default and fix Composite Editor