Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(filters): set date filter dynamically not always setting input value #1586

Merged
merged 2 commits into from
Jun 28, 2024

Conversation

ghiscoding
Copy link
Owner

  • calling Clear Filters, then Set Filters dynamically only worked once but not afterward
  • create a new Example 25 Filter Ranges example that displayed the bug found in downstream repos

- calling Clear Filters, then Set Filters dynamically only worked once but not afterward
Copy link

stackblitz bot commented Jun 28, 2024

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

Copy link

codecov bot commented Jun 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.8%. Comparing base (e89d1ad) to head (4f5087c).
Report is 1 commits behind head on master.

Additional details and impacted files
@@          Coverage Diff           @@
##           master   #1586   +/-   ##
======================================
  Coverage    99.8%   99.8%           
======================================
  Files         198     198           
  Lines       21777   21777           
  Branches     7293    7293           
======================================
  Hits        21716   21716           
+ Misses         61      55    -6     
- Partials        0       6    +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ghiscoding ghiscoding merged commit 5233be9 into master Jun 28, 2024
6 checks passed
@ghiscoding ghiscoding deleted the bugfix/dynamic-set-date-filter branch June 28, 2024 22:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant