Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core): rewrite "Empty Data" warning component to be in the canvas #157

Merged
merged 5 commits into from
Nov 13, 2020

Conversation

ghiscoding
Copy link
Owner

@ghiscoding ghiscoding commented Nov 12, 2020

  • remove all the previous absolute position as it was causing too many issues
  • instead create a component and place it within the grid-canvas on both left/right viewports which will work for both regular/frozen grids and also add options to hide any of the 2 sides when using frozen grid

image

Ghislain Beaulac added 3 commits November 12, 2020 17:15
- remove all the previous absolute position as it was causing too many issues
- instead create a component and place it within the grid-canvas on both left/right viewports which will work for both regular/frozen grids and also add options to hide any of the 2 sides when using frozen grid
@codecov
Copy link

codecov bot commented Nov 12, 2020

Codecov Report

Merging #157 (cf611cc) into master (78c80b4) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##            master      #157    +/-   ##
==========================================
  Coverage   100.00%   100.00%            
==========================================
  Files          198       198            
  Lines        11626     11637    +11     
  Branches      3813      3970   +157     
==========================================
+ Hits         11626     11637    +11     
Impacted Files Coverage Δ
.../common/src/services/groupingAndColspan.service.ts 100.00% <100.00%> (ø)
...le/src/components/slick-empty-warning.component.ts 100.00% <100.00%> (ø)
...bundle/src/components/slick-vanilla-grid-bundle.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 78c80b4...cf611cc. Read the comment docs.

@ghiscoding ghiscoding merged commit 78e2132 into master Nov 13, 2020
@ghiscoding ghiscoding deleted the bugfix/slick-empty-warning-offset branch November 13, 2020 03:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant