Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(filters): Compound Operator alt texts should work with custom list #1541

Merged
merged 4 commits into from
May 23, 2024

Conversation

ghiscoding
Copy link
Owner

@ghiscoding ghiscoding commented May 23, 2024

  • instead of applying the Compound Operator alternate texts from compoundOperatorNumeric or compoundOperatorString only, we should instead apply the alt texts after either a custom list or a fixed list from mentioned functions.

Copy link

stackblitz bot commented May 23, 2024

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@ghiscoding
Copy link
Owner Author

cc @zewa666

Copy link

codecov bot commented May 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.8%. Comparing base (a856d83) to head (b5483ac).
Report is 2 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff            @@
##           master   #1541     +/-   ##
========================================
+ Coverage    99.8%   99.8%   +0.1%     
========================================
  Files         198     198             
  Lines       21656   21662      +6     
  Branches     7236    6963    -273     
========================================
+ Hits        21595   21601      +6     
  Misses         61      61             

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ghiscoding ghiscoding merged commit 02d5d2b into master May 23, 2024
8 checks passed
@ghiscoding ghiscoding deleted the bugfix/compound-operator-alt-texts branch May 23, 2024 19:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants