Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): mem leaks w/orphan DOM elements when disposing #153

Merged
merged 3 commits into from
Nov 6, 2020

Conversation

ghiscoding
Copy link
Owner

No description provided.

@codecov
Copy link

codecov bot commented Nov 6, 2020

Codecov Report

Merging #153 (50063db) into master (6095c7c) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##            master      #153    +/-   ##
==========================================
  Coverage   100.00%   100.00%            
==========================================
  Files          196       196            
  Lines        11396     11468    +72     
  Branches      3878      3763   -115     
==========================================
+ Hits         11396     11468    +72     
Impacted Files Coverage Δ
packages/common/src/editors/autoCompleteEditor.ts 100.00% <100.00%> (ø)
packages/common/src/editors/checkboxEditor.ts 100.00% <100.00%> (ø)
packages/common/src/editors/dateEditor.ts 100.00% <100.00%> (ø)
packages/common/src/editors/floatEditor.ts 100.00% <100.00%> (ø)
packages/common/src/editors/integerEditor.ts 100.00% <100.00%> (ø)
packages/common/src/editors/longTextEditor.ts 100.00% <100.00%> (ø)
packages/common/src/editors/selectEditor.ts 100.00% <100.00%> (ø)
packages/common/src/editors/sliderEditor.ts 100.00% <100.00%> (ø)
packages/common/src/editors/textEditor.ts 100.00% <100.00%> (ø)
...ages/common/src/extensions/autoTooltipExtension.ts 100.00% <100.00%> (ø)
... and 23 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6095c7c...50063db. Read the comment docs.

@ghiscoding ghiscoding merged commit faba5a6 into master Nov 6, 2020
@ghiscoding ghiscoding deleted the feat/empty-data-warning branch November 6, 2020 18:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant