Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(editors): body click or Escape key should cancel Select Editor #1513

Merged
merged 1 commit into from
May 8, 2024

Conversation

ghiscoding
Copy link
Owner

  • add reason to onClose(reason) feature in external repo
  • Escape key should cancel any edit change (that would mostly only happen when multiple selection since single select would close after single selection
  • when clicking outside the select (body click), wouldn't call a save either

- add reason to `onClose(reason)` feature in external repo
- Escape key should cancel any edit change (that would mostly only happen when multiple selection since single select would close after single selection
- when clicking outside the select (body click), wouldn't call a save either
Copy link

stackblitz bot commented May 8, 2024

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

Copy link

codecov bot commented May 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.8%. Comparing base (e37bb28) to head (fdbfca6).

Additional details and impacted files
@@           Coverage Diff           @@
##            next   #1513     +/-   ##
=======================================
+ Coverage   99.8%   99.8%   +0.1%     
=======================================
  Files        198     198             
  Lines      21616   21623      +7     
  Branches    6945    7080    +135     
=======================================
+ Hits       21552   21559      +7     
+ Misses        64      58      -6     
- Partials       0       6      +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ghiscoding ghiscoding merged commit 3d765a9 into next May 8, 2024
6 checks passed
@ghiscoding ghiscoding deleted the bugfix/select-cancel-escape branch May 8, 2024 02:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant