fix(pubsub): externalize PubSub event to SlickEventData to stop bubbling #1444
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
preventDefault()
on the SlickEventData as well, for example the CompositeEditor demo has the eventonBeforeEditCell
and if the user calls thepreventDefault
even on the SlickEventData (e.g. with Aurelia or Angular), then the SlickGrid.notify
should receive areturnValue
offalse
because when the PubSub calls thedispatchEvent
with an event that was prevented, then thereturnValue
will befalse
, see MDN for reference: https://developer.mozilla.org/en-US/docs/Web/API/EventTarget/dispatchEvent#return_value