Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(editors): add changeEditorOption to all Editors which supports it #142

Merged
merged 10 commits into from
Oct 27, 2020

Conversation

ghiscoding
Copy link
Owner

No description provided.

@ghiscoding ghiscoding changed the title feat(editors): add changeEditorOption to Editors which can do it feat(editors): add changeEditorOption to all Editors who can do it Oct 26, 2020
@codecov
Copy link

codecov bot commented Oct 26, 2020

Codecov Report

Merging #142 into master will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #142   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          196       196           
  Lines        11359     11387   +28     
  Branches      3869      3876    +7     
=========================================
+ Hits         11359     11387   +28     
Impacted Files Coverage Δ
packages/common/src/editors/autoCompleteEditor.ts 100.00% <100.00%> (ø)
packages/common/src/editors/dateEditor.ts 100.00% <100.00%> (ø)
packages/common/src/editors/selectEditor.ts 100.00% <100.00%> (ø)
packages/common/src/services/gridState.service.ts 100.00% <100.00%> (ø)
packages/common/src/services/pagination.service.ts 100.00% <100.00%> (ø)
...src/components/slick-composite-editor.component.ts 100.00% <100.00%> (ø)
...ges/vanilla-bundle/src/services/resizer.service.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0c0d0bf...d338c28. Read the comment docs.

@ghiscoding ghiscoding changed the title feat(editors): add changeEditorOption to all Editors who can do it feat(editors): add changeEditorOption to all Editors which supports it Oct 27, 2020
@ghiscoding ghiscoding merged commit 97b1003 into master Oct 27, 2020
@ghiscoding ghiscoding deleted the feat/dynamically-change-editor-option branch October 27, 2020 19:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant