Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(styling): properly align flexbox ms-select icon+text vertically #1397

Merged
merged 3 commits into from
Feb 16, 2024

Conversation

ghiscoding
Copy link
Owner

@ghiscoding ghiscoding commented Feb 15, 2024

  • the ms-select icon+text label was never fully aligned in the middle, this PR fixes that by taking more advantage of flexbox. See print screen below, note that it wasn't by much, just an offset of a pixel or 2 (icon was slightly lower than the text position) but with this PR change, they are perfectly aligned
  • improve Material theme by increasing ms-select icon size
  • also fix wrong Material theme color used in demo for ms-select

before

icon was slightly lower than text

image

after

image

Copy link

codecov bot commented Feb 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (a30d590) 99.8% compared to head (c2e67d5) 99.8%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master   #1397    +/-   ##
=======================================
  Coverage    99.8%   99.8%            
=======================================
  Files         199     199            
  Lines       21559   21559            
  Branches     7204    7068   -136     
=======================================
  Hits        21495   21495            
+ Misses         64      58     -6     
- Partials        0       6     +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

- also fix ms-select color that were showing as blue instead of the expected green theme color
@ghiscoding ghiscoding merged commit e744d02 into master Feb 16, 2024
10 checks passed
@ghiscoding ghiscoding deleted the bugfix/ms-select-align branch February 16, 2024 03:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants