perf: decrease calls to setItems & grid invalidate #1363
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- with the previous implementation when dataset was provided through the constructor, it was internally calling `dataView.setItems(data)` twice, this PR will now only call it once and is much closer to the repos implementation which didn't have this issue (like Angular-Slickgrid) - remove unnecessary calls to `grid.invalidate()` - remove unnecessary calls to `grid.render()` when `grid.invalidate()` is used since that one already calls the render, so no need to do the same thing twice
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1363 +/- ##
========================================
- Coverage 99.7% 99.7% -0.0%
========================================
Files 199 199
Lines 21576 21567 -9
Branches 7202 7200 -2
========================================
- Hits 21496 21487 -9
Misses 73 73
Partials 7 7 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
dataView.setItems(data)twice, this PR will now only call it once and is much closer to the other repos implementation which didn't have this issue (like Angular-Slickgrid is fine, or actually it's calling twice but the first time is always empty so it doesn't have any impact)grid.invalidate()grid.render()whengrid.invalidate()is called just before, it is unnecessary since that the invalidate already calls the render internally, so no need to do the same thing twice