Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(styling): remove different bg-color on unorderable column #1358

Merged
merged 1 commit into from
Jan 22, 2024

Conversation

ghiscoding
Copy link
Owner

@ghiscoding ghiscoding commented Jan 22, 2024

It looks a little weird that the locked (unorderable) columns have different background-color especially when our grid doesn't have any borders around the headers. So I think it's better to remove it and fix the styling discrepancy by using the same bg-color for all column headers but keeping the SASS variable in case the user still want to change it

image

Copy link

codecov bot commented Jan 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (44f6c08) 99.7% compared to head (e2693be) 99.7%.
Report is 1 commits behind head on master.

Additional details and impacted files
@@          Coverage Diff           @@
##           master   #1358   +/-   ##
======================================
  Coverage    99.7%   99.7%           
======================================
  Files         199     199           
  Lines       21576   21576           
  Branches     7202    7202           
======================================
  Hits        21496   21496           
  Misses         73      73           
  Partials        7       7           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ghiscoding ghiscoding merged commit 91426d1 into master Jan 22, 2024
5 checks passed
@ghiscoding ghiscoding deleted the bugfix/unorderable-styling branch January 22, 2024 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants