fix: Editors/Filters should create SlickEventData with event arg #1326
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
ghiscoding
commented
Jan 12, 2024
•
ghiscoding
commented
- the previous code was to extend a SlickEventData with an Event but the correct way is to simply pass the Event to SlickEventData constructor as the first argument and we're done
- the previous code was to extend a SlickEventData with an Event but the correct way is to simply pass the Event to SlickEventData as the first argument and we're done
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1326 +/- ##
======================================
Coverage 98.0% 98.0%
======================================
Files 198 198
Lines 21284 21284
Branches 7093 7093
======================================
Hits 20845 20845
Misses 439 439 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.