fix(core): ensure to touch all nodes in package-graph, fix issue found by Jest team#301
Merged
ghiscoding merged 1 commit intomainfrom Aug 6, 2022
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## main #301 +/- ##
==========================================
+ Coverage 96.14% 96.14% +0.01%
==========================================
Files 145 145
Lines 4220 4221 +1
Branches 882 882
==========================================
+ Hits 4057 4058 +1
Misses 163 163
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
A previous PR introduced a way to "drastically reduce time taken to check for cycles" BUT had a very negative side effect reported by the Jest team here that caused a lot of packages to not be updated when they should have and not be published on npm when they should have. This PR fixes this issue by replicating a proposed solution in this Lerna PR 3234
Motivation and Context
The new issue reported by the Jest team was introduced by a previous PR #7 which had a negative side effect and caused a lot of packages to not be updated before publish (only 5 were updated when it should have been 43).
How Has This Been Tested?
Types of changes
Checklist: