Do not assume /usr/lib library installation.#3693
Merged
Merged
Conversation
Current `pkgconfig` configuration file installation path and its contents assume libraries are installed under `/usr/lib` and this is not always the case, for instance `/usr/lib64` is quite possible under Gentoo Linux. Thus use the `CMAKE_INSTALL_LIBDIR` variable instead of a hardcoded `lib`.
Member
|
@waptaff Thanks! |
danbev
added a commit
to danbev/whisper.cpp
that referenced
this pull request
Jun 2, 2026
This commit applies the same changes as Commit ef24de1 ("cmake : do not assume /usr/lib library installation. (ggml-org#3693)") but for parakeet. Refs: ggml-org#3693
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Current
pkgconfigconfiguration file installation path and its contents assume libraries are installed under/usr/liband this is not always the case, for instance/usr/lib64is quite possible under Gentoo Linux.Thus use the
CMAKE_INSTALL_LIBDIRvariable instead of a hardcodedlib.