perplexity : fix even more integer overflows#23623
Merged
ggerganov merged 1 commit intoMay 25, 2026
Merged
Conversation
CISC
approved these changes
May 24, 2026
CISC
added
the
merge ready
fewtarius
pushed a commit
to fewtarius/llama.cpp
that referenced
this pull request
May 30, 2026
Co-authored-by: Stanisław Szymczyk <sszymczy@gmail.com>
turbo-tan
pushed a commit
to turbo-tan/llama.cpp-tq3
that referenced
this pull request
Jun 2, 2026
Co-authored-by: Stanisław Szymczyk <sszymczy@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Fixed more integer overflows related to
n_ctxbeing multiplied bynvthat were still causing crashes with longer context sizes. Continuation of #23496.Fixes #23569.
Additional information
For models with large vocabulary and large context size
n_ctx * nvoverflows and becomes negative.Requirements