bug report: index overflow cause crash

[Josscii]

whisper.cpp/src/whisper.cpp

Line 7022 in a5abfe6

if (j < ns - 1 && tokens[j].t1 > tokens[j + 1].t0) {

j is compared with ns, which seems wrong, it should less than n, not ns.

[Josscii]

I do transcribe with turbo model, and it sometimes crash on this line

[Josscii]

@ggerganov

[ggerganov]

Thanks for finding this. Would you like to submit a PR?

[Josscii]

I can submit a pr, but I'm don't have a good understanding of the code, I only debuged it here, I'm afraid I would break some code

[ggerganov]

The fix is correct. ns is the number of samples, while the j iterator loops over the tokens, not the samples. This check is needed to guarantee that we don't do out-of-bounds access in the tokens array.

[Josscii]

Thanks for your explaination, I'll submit a pr