Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci : add building in MSYS2 environments (Windows) #1780

Closed
przemoc opened this issue Jan 18, 2024 · 2 comments
Closed

ci : add building in MSYS2 environments (Windows) #1780

przemoc opened this issue Jan 18, 2024 · 2 comments

Comments

@przemoc
Copy link
Contributor

przemoc commented Jan 18, 2024

I'm not familiar with GitHub Actions (yet), but it will be good to add most commonly used MSYS2 environments to CI for build sanity checks:

  • UCRT64 (default since 2022-10-29, previously it was MINGW64 relying on old msvcrt.dll),
  • CLANG64 (it's good to not rely on gcc only)
  • CLANG32 (only if we want to have coverage in 32-bit builds too) - optional

MSYS2 does not support older Windows for quite some time already, so there is no point in targeting msvcrt-based environments (MINGW64 and MINGW32).

Environment details can be found on page:
https://www.msys2.org/docs/environments/

GitHub Action to setup MSYS2:
https://github.com/msys2/setup-msys2


Depending on configuration (like enabling OpenBLAS), right now bulding in MSYS2 environments is not always working out of the box, but it was being improved in 2023, and is continued being improved directly (#1772) or indirectly (#1778).

Initially simple configurations (like w/o BLAS) could be built and in future expanded to cover more variants.

@przemoc
Copy link
Contributor Author

przemoc commented Mar 25, 2024

Heads-up: I got windows-msys2 job in GitHub Actions successfully building whisper.cpp via make on UCRT64 and CLANG64 in my own branch on top of #1778, but will have to expand it to test not only via make but also via cmake and with OpenBLAS too (hence dependence on the other PR).

When I will have something relatively ready to share, I will create a dedicated PR.

@przemoc
Copy link
Contributor Author

przemoc commented Mar 31, 2024

Forgot to close this issue after PR got merged.

@przemoc przemoc closed this as completed Mar 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant