Null nested models are instantiated (with null fields).

[PtiPingouin]

Consider the following code, where Model2 is also a table:

@Table
public class Model1 {
    @Nullable
    protected Model2 model2;
}

When reading from database an instance of Model1 that has no model2, model1 still gets a model2 instance, with null values.

In Model1_Schema, I can see there are no condition for instantiating model2:

  @NonNull
  @Override
  public Model1 newModelFromCursor(@NonNull OrmaConnection conn, @NonNull Cursor cursor, int offset) {
    Model1 model = new Model1();
    model.setModel2(Model2_Schema.INSTANCE.newModelFromCursor(...));
    return model;
  }

Model2_Schema.INSTANCE.newModelFromCursor() is called no matter what.

Am I missing something?

[gfx]

What's your Orma version?

[PtiPingouin]

3.0.0-rc3

[gfx]

Seems bugs. Will investigate it.

[PtiPingouin]

Thanks

[gfx]

NOTE: This issue should be fixed in #263 but the PR didn't solve it.

[gfx]

Released v3.0.0-rc4 with this bug fix. Can you try it please?

[PtiPingouin]

Ok

On Tue, Oct 11, 2016 at 4:40 PM, FUJI Goro [email protected] wrote:

Released v3.0.0-rc4 with this bug fix. Can you try it please?

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#301 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AA2BLMqwRbKNos9XPN9cwYLqqGX-2rEMks5qy5_DgaJpZM4KTdWC
.